This project is read-only.
1
Vote

Static Analysis Flag

description

BangoAgentImpl::EventNameAllowed() has several uses of == when comparing strings. Doesn't seem to affect functionality, but our static scans don't like it. Propose updating to using String.equals() in such cases.

Also see BangoLogger::PostEvents() (line 392 in my version). It uses: _userAgent != "".

And finally BangoLogger::GetApplicationVersion() (line 485) has returnValue == "".

comments

bangogreg wrote Jun 21, 2013 at 8:58 AM

Code has been updated.